Skip to content

fix: ignore generated migration manifests in templates - #2557

Merged
ascorbic merged 7 commits into
mainfrom
fix/template-migration-manifest-ignore
Aug 19, 2026
Merged

fix: ignore generated migration manifests in templates#2557
ascorbic merged 7 commits into
mainfrom
fix/template-migration-manifest-ignore

Conversation

@ascorbic

@ascorbic ascorbic commented Aug 19, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

What does this PR do?

Ignores the generated .emdash/migrations.json manifest in all nine shipped templates so an Astro build does not leave a new site with an untracked file. Documents the same rule for existing sites and updates the existing deployment migration changeset while preserving its association with #2437.

Follow-up to #2437.

Type of change

  • Bug fix
  • Feature (requires maintainer-approved Discussion)
  • Refactor (no behavior change)
  • Translation
  • Documentation
  • Performance improvement
  • Tests
  • Chore (dependencies, CI, tooling)

Checklist

  • I have read CONTRIBUTING.md
  • pnpm typecheck passes
  • pnpm lint passes
  • pnpm test passes (or targeted tests for my change)
  • pnpm format has been run
  • I have added/updated tests for my changes (if applicable)
  • User-visible strings in the admin UI are wrapped for translation (if applicable). Do not include messages.po changes except in translation PRs — a workflow extracts catalogs on merge to main.
  • I have added a changeset (if this PR changes a published package)
  • New features link to an approved Discussion: not applicable; this is a bug fix

No new test file is needed for static ignore metadata. A targeted check verifies that every shipped template ignores .emdash/migrations.json exactly once. The change has no admin UI strings.

AI-generated code disclosure

  • This PR includes AI-generated code — model/tool: Codex (GPT-5)

Screenshots / test output

Not applicable; this change has no visual output.

Copilot AI lite review requested due to automatic review settings August 19, 2026 10:07
@changeset-bot

changeset-bot Bot commented Aug 19, 2026 •
edited
Loading

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 8c77fed

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes changesets to release 17 packages
Name Type
emdash Minor
@emdash-cms/cloudflare Minor
@emdash-cms/sandbox-workerd Patch
@emdash-cms/plugin-mcp-smoke Major
@emdash-cms/fixture-perf-site Patch
@emdash-cms/perf-demo-site Patch
@emdash-cms/cache-demo-site Patch
@emdash-cms/do-demo-site Patch
@emdash-cms/do-solo-demo-site Patch
@emdash-cms/admin Minor
@emdash-cms/auth Minor
@emdash-cms/blocks Minor
@emdash-cms/gutenberg-to-portable-text Minor
@emdash-cms/x402 Minor
create-emdash Minor
@emdash-cms/auth-atproto Patch
@emdash-cms/plugin-embeds Patch

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copilot AI reviewed Aug 19, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@github-actions github-actions Bot added review/awaiting-author Reviewed; waiting on the author to respond area/templates size/S cla: signed labels Aug 19, 2026
@pkg-pr-new

pkg-pr-new Bot commented Aug 19, 2026 •
edited
Loading

Copy link
Copy Markdown

Open in StackBlitz

@emdash-cms/admin

npm i https://pkg.pr.new/@emdash-cms/admin@2557

@emdash-cms/auth

npm i https://pkg.pr.new/@emdash-cms/auth@2557

@emdash-cms/auth-atproto

npm i https://pkg.pr.new/@emdash-cms/auth-atproto@2557

@emdash-cms/blocks

npm i https://pkg.pr.new/@emdash-cms/blocks@2557

@emdash-cms/cloudflare

npm i https://pkg.pr.new/@emdash-cms/cloudflare@2557

@emdash-cms/contentful-to-portable-text

npm i https://pkg.pr.new/@emdash-cms/contentful-to-portable-text@2557

emdash

npm i https://pkg.pr.new/emdash@2557

create-emdash

npm i https://pkg.pr.new/create-emdash@2557

@emdash-cms/gutenberg-to-portable-text

npm i https://pkg.pr.new/@emdash-cms/gutenberg-to-portable-text@2557

@emdash-cms/plugin-cli

npm i https://pkg.pr.new/@emdash-cms/plugin-cli@2557

@emdash-cms/plugin-types

npm i https://pkg.pr.new/@emdash-cms/plugin-types@2557

@emdash-cms/registry-client

npm i https://pkg.pr.new/@emdash-cms/registry-client@2557

@emdash-cms/registry-lexicons

npm i https://pkg.pr.new/@emdash-cms/registry-lexicons@2557

@emdash-cms/registry-verification

npm i https://pkg.pr.new/@emdash-cms/registry-verification@2557

@emdash-cms/sandbox-workerd

npm i https://pkg.pr.new/@emdash-cms/sandbox-workerd@2557

@emdash-cms/x402

npm i https://pkg.pr.new/@emdash-cms/x402@2557

@emdash-cms/plugin-ai-moderation

npm i https://pkg.pr.new/@emdash-cms/plugin-ai-moderation@2557

@emdash-cms/plugin-atproto

npm i https://pkg.pr.new/@emdash-cms/plugin-atproto@2557

@emdash-cms/plugin-audit-log

npm i https://pkg.pr.new/@emdash-cms/plugin-audit-log@2557

@emdash-cms/plugin-color

npm i https://pkg.pr.new/@emdash-cms/plugin-color@2557

@emdash-cms/plugin-embeds

npm i https://pkg.pr.new/@emdash-cms/plugin-embeds@2557

@emdash-cms/plugin-field-kit

npm i https://pkg.pr.new/@emdash-cms/plugin-field-kit@2557

@emdash-cms/plugin-forms

npm i https://pkg.pr.new/@emdash-cms/plugin-forms@2557

@emdash-cms/plugin-webhook-notifier

npm i https://pkg.pr.new/@emdash-cms/plugin-webhook-notifier@2557

commit: 8c77fed

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Aug 19, 2026 •
edited
Loading

Copy link
Copy Markdown

🚀 Deploying Preview to Cloudflare 🚀

Preview Deployments by commit

Status Deployment URL Commit Updated (UTC) See this deployment's details
  • Build: Success ✅

View logs ↗		 8c77fed 2026-08-19T12:24:09.654Z Visit the dashboard ↗
  • Build: Success ✅

View logs ↗		 71e0bf5 2026-08-19T10:31:46.942Z Visit the dashboard ↗
  • Build: Success ✅

View logs ↗		 1cdae5c 2026-08-19T10:26:53.739Z Visit the dashboard ↗
  • Build: Success ✅

View logs ↗		 eb26bf8 2026-08-19T10:14:10.132Z Visit the dashboard ↗
  • Build: Success ✅

View logs ↗		 22fb438 2026-08-19T10:10:32.428Z Visit the dashboard ↗

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Aug 19, 2026 •
edited
Loading

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Updated (UTC)
✅ Deployment successful!
View logs		 docs 8c77fed Aug 19 2026, 12:21 PM

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Aug 19, 2026 •
edited
Loading

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Updated (UTC)
✅ Deployment successful!
View logs		 emdash-demo-do 8c77fed Aug 19 2026, 12:21 PM

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Aug 19, 2026 •
edited
Loading

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Updated (UTC)
✅ Deployment successful!
View logs		 emdash-demo-cache 8c77fed Aug 19 2026, 12:19 PM

@github-actions github-actions Bot added review/needs-rereview Author pushed changes since the last review area/docs and removed review/awaiting-author Reviewed; waiting on the author to respond labels Aug 19, 2026
@github-actions github-actions Bot added size/M and removed size/S labels Aug 19, 2026
@ascorbic
ascorbic enabled auto-merge (squash) August 19, 2026 13:27
@ascorbic
ascorbic merged commit ce562c0 into main Aug 19, 2026
71 of 72 checks passed
@ascorbic
ascorbic deleted the fix/template-migration-manifest-ignore branch August 19, 2026 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments

Assignees

No one assigned

Labels

area/docs area/templates cla: signed review/needs-rereview Author pushed changes since the last review size/M

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ascorbic